FindBugs Bug Detector Report
The following document contains the results of FindBugs
FindBugs Version is 3.0.1
Threshold is
Effort is min
Summary
| Classes |
Bugs |
Errors |
Missing Classes |
| 274 |
69 |
0 |
0 |
davmail.DavGateway$1
| Bug |
Category |
Details |
Line |
Priority |
| Naked notify in davmail.DavGateway$1.run() |
MT_CORRECTNESS |
NN_NAKED_NOTIFY |
121 |
Medium |
davmail.exchange.ExchangeSession
| Bug |
Category |
Details |
Line |
Priority |
| davmail.exchange.ExchangeSession.CONTACT_ATTRIBUTES is a mutable collection |
MALICIOUS_CODE |
MS_MUTABLE_COLLECTION |
2948 |
High |
| davmail.exchange.ExchangeSession.DISTRIBUTION_LIST_ATTRIBUTES is a mutable collection |
MALICIOUS_CODE |
MS_MUTABLE_COLLECTION |
3017 |
High |
| davmail.exchange.ExchangeSession.IMAP_MESSAGE_ATTRIBUTES is a mutable collection |
MALICIOUS_CODE |
MS_MUTABLE_COLLECTION |
267 |
High |
| davmail.exchange.ExchangeSession.POP_MESSAGE_ATTRIBUTES is a mutable collection which should be package protected |
MALICIOUS_CODE |
MS_MUTABLE_COLLECTION_PKGPROTECT |
248 |
Medium |
| davmail.exchange.ExchangeSession.SPECIAL is a mutable collection which should be package protected |
MALICIOUS_CODE |
MS_MUTABLE_COLLECTION_PKGPROTECT |
83 |
Medium |
| davmail.exchange.ExchangeSession.UID_MESSAGE_ATTRIBUTES is a mutable collection which should be package protected |
MALICIOUS_CODE |
MS_MUTABLE_COLLECTION_PKGPROTECT |
288 |
Medium |
davmail.exchange.ExchangeSession$MessageList
| Bug |
Category |
Details |
Line |
Priority |
| davmail.exchange.ExchangeSession$MessageList is Serializable; consider declaring a serialVersionUID |
BAD_PRACTICE |
SE_NO_SERIALVERSIONID |
1726 |
Medium |
davmail.exchange.ExchangeSessionFactory
| Bug |
Category |
Details |
Line |
Priority |
| Switch statement found in davmail.exchange.ExchangeSessionFactory.getInstance(String, String, String) where default case is missing |
STYLE |
SF_SWITCH_NO_DEFAULT |
161-172 |
Medium |
davmail.exchange.VCalendar
| Bug |
Category |
Details |
Line |
Priority |
| Uninitialized read of vTimezone in new davmail.exchange.VCalendar(BufferedReader, String, VObject) |
CORRECTNESS |
UR_UNINIT_READ |
55 |
High |
davmail.exchange.VProperty
| Bug |
Category |
Details |
Line |
Priority |
| davmail.exchange.VProperty.MULTIVALUED_PROPERTIES is a mutable collection which should be package protected |
MALICIOUS_CODE |
MS_MUTABLE_COLLECTION_PKGPROTECT |
32 |
Medium |
davmail.exchange.auth.ExchangeFormAuthenticator
| Bug |
Category |
Details |
Line |
Priority |
| davmail.exchange.auth.ExchangeFormAuthenticator.PASSWORD_FIELDS is a mutable collection which should be package protected |
MALICIOUS_CODE |
MS_MUTABLE_COLLECTION_PKGPROTECT |
87 |
Medium |
| davmail.exchange.auth.ExchangeFormAuthenticator.TOKEN_FIELDS is a mutable collection which should be package protected |
MALICIOUS_CODE |
MS_MUTABLE_COLLECTION_PKGPROTECT |
102 |
Medium |
| davmail.exchange.auth.ExchangeFormAuthenticator.USER_NAME_FIELDS is a mutable collection which should be package protected |
MALICIOUS_CODE |
MS_MUTABLE_COLLECTION_PKGPROTECT |
72 |
Medium |
davmail.exchange.auth.O365ManualAuthenticator
| Bug |
Category |
Details |
Line |
Priority |
| Found reliance on default encoding in davmail.exchange.auth.O365ManualAuthenticator.getCodeFromConsole(String): new java.io.InputStreamReader(InputStream) |
I18N |
DM_DEFAULT_ENCODING |
132 |
High |
davmail.exchange.dav.DavExchangeSession
davmail.exchange.dav.Field
| Bug |
Category |
Details |
Line |
Priority |
| davmail.exchange.dav.Field.distinguishedPropertySetMap is a mutable collection which should be package protected |
MALICIOUS_CODE |
MS_MUTABLE_COLLECTION_PKGPROTECT |
40 |
Medium |
| davmail.exchange.dav.Field.fieldMap is a mutable collection which should be package protected |
MALICIOUS_CODE |
MS_MUTABLE_COLLECTION_PKGPROTECT |
89 |
Medium |
| davmail.exchange.dav.Field.propertyTypeMap is a mutable collection which should be package protected |
MALICIOUS_CODE |
MS_MUTABLE_COLLECTION_PKGPROTECT |
72 |
Medium |
davmail.exchange.ews.EWSMethod$Item
| Bug |
Category |
Details |
Line |
Priority |
| Class davmail.exchange.ews.EWSMethod$Item defines non-transient non-serializable instance field attachments |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
Medium |
| Class davmail.exchange.ews.EWSMethod$Item defines non-transient non-serializable instance field attendees |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
Medium |
| Class davmail.exchange.ews.EWSMethod$Item defines non-transient non-serializable instance field fieldUpdates |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
Medium |
| Class davmail.exchange.ews.EWSMethod$Item defines non-transient non-serializable instance field occurrences |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
Medium |
davmail.exchange.ews.EwsExchangeSession
| Bug |
Category |
Details |
Line |
Priority |
| davmail.exchange.ews.EwsExchangeSession.CALENDAR_ITEM_REQUEST_PROPERTIES is a mutable collection which should be package protected |
MALICIOUS_CODE |
MS_MUTABLE_COLLECTION_PKGPROTECT |
2377 |
Medium |
| davmail.exchange.ews.EwsExchangeSession.EVENT_REQUEST_PROPERTIES is a mutable collection which should be package protected |
MALICIOUS_CODE |
MS_MUTABLE_COLLECTION_PKGPROTECT |
2362 |
Medium |
| davmail.exchange.ews.EwsExchangeSession.FOLDER_PROPERTIES is a mutable collection which should be package protected |
MALICIOUS_CODE |
MS_MUTABLE_COLLECTION_PKGPROTECT |
1022 |
Medium |
| davmail.exchange.ews.EwsExchangeSession.GALFIND_ATTRIBUTE_MAP is a mutable collection which should be package protected |
MALICIOUS_CODE |
MS_MUTABLE_COLLECTION_PKGPROTECT |
2948 |
Medium |
| davmail.exchange.ews.EwsExchangeSession.IGNORE_ATTRIBUTE_SET is a mutable collection which should be package protected |
MALICIOUS_CODE |
MS_MUTABLE_COLLECTION_PKGPROTECT |
2980 |
Medium |
| davmail.exchange.ews.EwsExchangeSession.ITEM_PROPERTIES is a mutable collection which should be package protected |
MALICIOUS_CODE |
MS_MUTABLE_COLLECTION_PKGPROTECT |
2351 |
Medium |
| davmail.exchange.ews.EwsExchangeSession.MESSAGE_TYPES is a mutable collection which should be package protected |
MALICIOUS_CODE |
MS_MUTABLE_COLLECTION_PKGPROTECT |
73 |
Medium |
| davmail.exchange.ews.EwsExchangeSession.importanceToPriorityMap is a mutable collection which should be package protected |
MALICIOUS_CODE |
MS_MUTABLE_COLLECTION_PKGPROTECT |
3174 |
Medium |
| davmail.exchange.ews.EwsExchangeSession.priorityToImportanceMap is a mutable collection which should be package protected |
MALICIOUS_CODE |
MS_MUTABLE_COLLECTION_PKGPROTECT |
3182 |
Medium |
davmail.exchange.ews.EwsExchangeSession$AttributeCondition
| Bug |
Category |
Details |
Line |
Priority |
| Redundant nullcheck of fieldURI, which is known to be non-null in davmail.exchange.ews.EwsExchangeSession$AttributeCondition.getFieldURI() |
STYLE |
RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE |
789 |
Medium |
davmail.exchange.ews.EwsExchangeSession$Event
| Bug |
Category |
Details |
Line |
Priority |
| Switch statement found in davmail.exchange.ews.EwsExchangeSession$Event.buildFieldUpdates(VCalendar, VObject, boolean) where default case is missing |
STYLE |
SF_SWITCH_NO_DEFAULT |
1676-1687 |
Medium |
davmail.exchange.ews.RecurrenceFieldUpdate
| Bug |
Category |
Details |
Line |
Priority |
| davmail.exchange.ews.RecurrenceFieldUpdate.setEndDate(Date) may expose internal representation by storing an externally mutable object into RecurrenceFieldUpdate.endDate |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
57 |
Medium |
| davmail.exchange.ews.RecurrenceFieldUpdate.setStartDate(Date) may expose internal representation by storing an externally mutable object into RecurrenceFieldUpdate.startDate |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
53 |
Medium |
davmail.http.DavGatewaySSLSocketFactory
| Bug |
Category |
Details |
Line |
Priority |
| davmail.http.DavGatewaySSLSocketFactory.createSSLContext() might ignore java.lang.Exception |
BAD_PRACTICE |
DE_MIGHT_IGNORE |
115 |
Medium |
| Exception is caught when Exception is not thrown in davmail.http.DavGatewaySSLSocketFactory.createSSLContext() |
STYLE |
REC_CATCH_EXCEPTION |
115 |
Medium |
davmail.http.DavGatewayX509TrustManager
| Bug |
Category |
Details |
Line |
Priority |
| Found reliance on default encoding in davmail.http.DavGatewayX509TrustManager.isCertificateTrusted(X509Certificate): new java.io.InputStreamReader(InputStream) |
I18N |
DM_DEFAULT_ENCODING |
107 |
High |
davmail.http.DavMailX509KeyManager
| Bug |
Category |
Details |
Line |
Priority |
| Found reliance on default encoding in davmail.http.DavMailX509KeyManager.chooseClientAlias(String[], String[]): new java.io.InputStreamReader(InputStream) |
I18N |
DM_DEFAULT_ENCODING |
168 |
High |
davmail.http.HttpClientAdapter
| Bug |
Category |
Details |
Line |
Priority |
| Redundant nullcheck of davmail.http.HttpClientAdapter.provider, which is known to be non-null in new davmail.http.HttpClientAdapter(URI, String, String, boolean) |
STYLE |
RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE |
230 |
Medium |
| Unread field: davmail.http.HttpClientAdapter.userEmail |
PERFORMANCE |
URF_UNREAD_FIELD |
314 |
Medium |
davmail.http.KerberosHelper
| Bug |
Category |
Details |
Line |
Priority |
davmail.http.KerberosHelper$KerberosCallbackHandler
| Bug |
Category |
Details |
Line |
Priority |
| Found reliance on default encoding in davmail.http.KerberosHelper$KerberosCallbackHandler.handle(Callback[]): new java.io.InputStreamReader(InputStream) |
I18N |
DM_DEFAULT_ENCODING |
72 |
High |
davmail.http.KerberosLoginConfiguration
| Bug |
Category |
Details |
Line |
Priority |
| davmail.http.KerberosLoginConfiguration.getAppConfigurationEntry(String) may expose internal representation by returning KerberosLoginConfiguration.CLIENT_LOGIN_MODULE |
MALICIOUS_CODE |
EI_EXPOSE_REP |
81 |
Medium |
| davmail.http.KerberosLoginConfiguration.getAppConfigurationEntry(String) may expose internal representation by returning KerberosLoginConfiguration.SERVER_LOGIN_MODULE |
MALICIOUS_CODE |
EI_EXPOSE_REP |
83 |
Medium |
| davmail.http.KerberosLoginConfiguration.CLIENT_LOGIN_MODULE should be package protected |
MALICIOUS_CODE |
MS_PKGPROTECT |
59 |
Medium |
| davmail.http.KerberosLoginConfiguration.SERVER_LOGIN_MODULE should be package protected |
MALICIOUS_CODE |
MS_PKGPROTECT |
72 |
Medium |
davmail.http.request.ExchangePropFindRequest
| Bug |
Category |
Details |
Line |
Priority |
| Return value of org.apache.jackrabbit.webdav.property.DavPropertyName.getName() ignored, but method has no side effect |
STYLE |
RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT |
66 |
Medium |
davmail.imap.ImapConnection
| Bug |
Category |
Details |
Line |
Priority |
| davmail.imap.ImapConnection.handleRefresh(TreeMap, TreeMap) makes inefficient use of keySet iterator instead of entrySet iterator |
PERFORMANCE |
WMI_WRONG_MAP_ITERATOR |
804 |
Medium |
davmail.ldap.BerDecoder
| Bug |
Category |
Details |
Line |
Priority |
| new davmail.ldap.BerDecoder(byte[], int, int) may expose internal representation by storing an externally mutable object into BerDecoder.buf |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
46 |
Medium |
davmail.ldap.BerEncoder
| Bug |
Category |
Details |
Line |
Priority |
| davmail.ldap.BerEncoder.getBuf() may expose internal representation by returning BerEncoder.buf |
MALICIOUS_CODE |
EI_EXPOSE_REP |
103 |
Medium |
davmail.ldap.HexDumpEncoder
| Bug |
Category |
Details |
Line |
Priority |
| Found reliance on default encoding in davmail.ldap.HexDumpEncoder.encodeBuffer(byte[]): java.io.ByteArrayOutputStream.toString() |
I18N |
DM_DEFAULT_ENCODING |
307 |
High |
| Found reliance on default encoding in davmail.ldap.HexDumpEncoder.encodeBufferPrefix(OutputStream): new java.io.PrintStream(OutputStream) |
I18N |
DM_DEFAULT_ENCODING |
85 |
High |
davmail.ldap.LdapConnection$SearchRunnable
| Bug |
Category |
Details |
Line |
Priority |
| Switch statement found in davmail.ldap.LdapConnection$SearchRunnable.sendPersons(int, String, Map, Set) where default case is missing |
STYLE |
SF_SWITCH_NO_DEFAULT |
1647-1655 |
Medium |
davmail.service.DavService
| Bug |
Category |
Details |
Line |
Priority |
| Unconditional wait in davmail.service.DavService.serviceMain(String[]) |
MT_CORRECTNESS |
UW_UNCOND_WAIT |
76 |
Medium |
| Wait not in loop in davmail.service.DavService.serviceMain(String[]) |
MT_CORRECTNESS |
WA_NOT_IN_LOOP |
76 |
Medium |
davmail.ui.SelectCertificateDialog
| Bug |
Category |
Details |
Line |
Priority |
| new davmail.ui.SelectCertificateDialog(String[], String[]) may expose internal representation by storing an externally mutable object into SelectCertificateDialog.aliases |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
51 |
Medium |
davmail.ui.tray.AwtGatewayTray
| Bug |
Category |
Details |
Line |
Priority |
| davmail.ui.tray.AwtGatewayTray.activeImage should be package protected |
MALICIOUS_CODE |
MS_PKGPROTECT |
Not available |
Medium |
| davmail.ui.tray.AwtGatewayTray.frameIcons should be package protected |
MALICIOUS_CODE |
MS_PKGPROTECT |
Not available |
Medium |
| davmail.ui.tray.AwtGatewayTray.image should be package protected |
MALICIOUS_CODE |
MS_PKGPROTECT |
Not available |
Medium |
| davmail.ui.tray.AwtGatewayTray.inactiveImage should be package protected |
MALICIOUS_CODE |
MS_PKGPROTECT |
Not available |
Medium |
davmail.ui.tray.SwtGatewayTray$1
| Bug |
Category |
Details |
Line |
Priority |
| davmail.ui.tray.SwtGatewayTray$1.run() invokes System.exit(...), which shuts down the entire virtual machine |
BAD_PRACTICE |
DM_EXIT |
346 |
Medium |
